Re: [PATCH v4 0/3] Use default values from settings instead of config

From: Glen Choo <chooglen@google.com>
Date: Oct 14, 2021, 22:21 UTC
Message-ID: <kl6l7def1c4h.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <d553054f-a484-ba34-ef3b-1e6778211a47@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 15 quoted lines

>>> The commit-graph should be disabled if replace-objects are enabled. If
>>> there is a bug being introduced here it is because the commit-graph is
>>> being checked during fsck even though it would never be read when the
>>> replace-objects exist.
>>>
>>> Thanks,
>>> -Stolee
>> 
>> Thanks, isn't the obvious fix for this to extend your d6538246d3d
>> (commit-graph: not compatible with replace objects, 2018-08-20) to do
>> "read_replace_refs = 0;" in graph_verify()? That works for me on this
>> case.
>
> Ignoring the replace refs while verifying will allow you to verify the
> on-disk commit-graph file without issue.

It seems like we've converged on doing read_replace_refs = 0 \o/

If we are going to do this twice in graph_verify() and graph_write(), is there any reason why I shouldn't just do "read_replace_refs = 0" once in cmd_commit_graph()? IOW any time we do anything with commit-graphs, we should just ignore replace refs because they're incompatible.