Re: [PATCH 3/3] gc: perform incremental repack when implictly enabled

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Sep 14, 2021, 04:00 UTC
Message-ID: <e890300b-4a9d-8c08-84f2-c20b28214da2@gmail.com>
In-Reply-To: <20210913181221.42635-4-chooglen@google.com>

On 14/09/21 01.12, Glen Choo wrote:

Show 10 quoted lines

> builtin/gc.c has two ways of checking of multi-pack-index is enabled:
> - git_config_get_bool() in incremental_repack_auto_condition()
> - the_repository->settings.core_multi_pack_index in
>    maintenance_task_incremental_repack()
> 
> the_repository->settings.core_multi_pack_index should be preferred
> because it has default values from prepare_repo_settings().
> 
> Standardize on the_repository->settings.core_multi_pack_index to check
> if multi-pack-index is enabled.

I was wonder what the correlations between checking if MIDX is enabled and performing incremental repack are. What are these?

-- 
An old man doll... just what I always wanted! - Clara