Re: [PATCH 3/3] gc: perform incremental repack when implictly enabled

From: Glen Choo <chooglen@google.com>
Date: Sep 16, 2021, 17:15 UTC
Message-ID: <YUN7qEJ2C9wuAuEu@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <e890300b-4a9d-8c08-84f2-c20b28214da2@gmail.com>

On Tue, Sep 14, 2021 at 11:00:34AM +0700, Bagas Sanjaya wrote:

> I was wonder what the correlations between checking if MIDX is enabled and
> performing incremental repack are. What are these?

(I'm not an expert on the issue, so don't take what I say as definitive :))

Here's what I was able to find in Documentation/git-maintenance.txt:

  The `incremental-repack` job repacks the object directory
	using the `multi-pack-index` feature.[...]

My guess at the intended behavior is that disabling midx should make git-maintenance behave as if it were unaware of midx features, such as incremental repack. This is quite akin to the documented behavior of fsck in this patch series, where fsck only verifies midx and commit-graphs when the respective features are enabled.