git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] coccicheck: fail "make" when it fails

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Jun 21, 2025, 06:29 UTC
Message-ID
<jyof56xql2c23gyckxzmry4smkt2uk64lyofqxk34olzn7evgf@ltq5tiqo4qyg>
In-Reply-To
<xmqqwm97bv7c.fsf@gitster.g>
On Thu, Jun 19, 2025 at 08:35:35AM -0800, Junio C Hamano wrote:
Show 13 quoted lines
> 
> diff --git c/Makefile w/Makefile
> index 70d1543b6b..2c17868a24 100644
> --- c/Makefile
> +++ w/Makefile
> @@ -3475,8 +3475,10 @@ coccicheck-test: $(COCCI_TEST_RES_GEN)
>  coccicheck: coccicheck-test
>  ifdef SPATCH_CONCAT_COCCI
>  coccicheck: contrib/coccinelle/ALL.cocci.patch
> +	! test -s contrib/coccinelle/ALL.cocci.patch
>  else
>  coccicheck: $(COCCICHECK_PATCHES_INTREE)
> +	test $$(cat $(COCCICHECK_PATCHES_INTREE) | wc -c) = 0

Definitely a nitpick, but I think using `-eq` instead of `=` and might even come handy from a portability point of view.

Just like Peff, agree would be a big improvement to have this changed for usability.

Carlo
Previous: Jeff KingNext: Eric Sunshine
Message 3 of 6 in “coccicheck: fail "make" when it fails”
  1. coccicheck: fail "make" when it failsJunio C Hamano, Jun 19, 2025
  2. Jeff KingJun 21, 2025
  3. Carlo Marcelo Arenas BelónJun 21, 2025
  4. Eric SunshineJun 21, 2025
  5. Junio C HamanoJun 22, 2025
  6. coccicheck: fail "make" when it failsJunio C Hamano, Jun 23, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.