git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] coccicheck: fail "make" when it fails

From
Jeff King <peff@peff.net>
Date
Jun 21, 2025, 05:16 UTC
Message-ID
<20250621051651.GB3002138@coredump.intra.peff.net>
In-Reply-To
<xmqqwm97bv7c.fsf@gitster.g>
On Thu, Jun 19, 2025 at 08:35:35AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> With "make coccicheck", we generate contrib/coccinelle/*.cocci.patch
> files that contain changes suggested by semantic patches, but "make"
> succeeds.  Admittedly, not many developers may run "make coccicheck"
> in the first place, but it makes it harder to notice when they do
> run it after they introduced an iffy piece of code.

I admit that I do not run coccicheck very often. But I have definitely been surprised by it not triggering a make failure when there are changes to be made. So I'd be in favor of this patch.

-Peff
Previous: Junio C HamanoNext: Carlo Marcelo Arenas Belón
Message 2 of 6 in “coccicheck: fail "make" when it fails”
  1. coccicheck: fail "make" when it failsJunio C Hamano, Jun 19, 2025
  2. Jeff KingJun 21, 2025
  3. Carlo Marcelo Arenas BelónJun 21, 2025
  4. Eric SunshineJun 21, 2025
  5. Junio C HamanoJun 22, 2025
  6. coccicheck: fail "make" when it failsJunio C Hamano, Jun 23, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.