Re: [RFC PATCH] coccicheck: fail "make" when it fails

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 21, 2025, 08:09 UTC
Message-ID: <CAPig+cRtSzjA=P_-WhRw9rRmTmFMGibKuHYn_ZuN935fcffveg@mail.gmail.com>
In-Reply-To: <jyof56xql2c23gyckxzmry4smkt2uk64lyofqxk34olzn7evgf@ltq5tiqo4qyg>

On Sat, Jun 21, 2025 at 2:29 AM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 6 quoted lines

> On Thu, Jun 19, 2025 at 08:35:35AM -0800, Junio C Hamano wrote:
> >  coccicheck: $(COCCICHECK_PATCHES_INTREE)
> > +     test $$(cat $(COCCICHECK_PATCHES_INTREE) | wc -c) = 0
>
> Definitely a nitpick, but I think using `-eq` instead of `=`
> and might even come handy from a portability point of view.

Junio has previously expressed[*] a preference for `=` over `-eq` in this sort of situation.

[*]: https://lore.kernel.org/git/7v8v3m50ds.fsf@alter.siamese.dyndns.org/