Re: [PATCH 03/16] reftable/blocksource: consolidate code into a single file

From: Justin Tobler <jltobler@gmail.com>
Date: Apr 2, 2025, 17:42 UTC
Message-ID: <i2zpjkbunx5ilmdtjns6dhsuuc7vdncpz3se3my43sajqqjsrf@c7jj2h3z7f3o>
In-Reply-To: <20250331-pks-reftable-polishing-v1-3-ebed5247434c@pks.im>

On 25/03/31 10:41AM, Patrick Steinhardt wrote:

> The code that implements block sources is distributed across a couple of
> files even though. Consolidate all of it into "reftable/blocksource.c"

even though... ? I think you meant to followup with something here.

> and its accompanying header so that it is easier to locate and more self
> contained.

It looks like some of the block source function get renamed in the process. It might we worth mentioning that in the commit message too. Other than that, everything else in this patch seems to be a simple reorganization. Looks good!

-Justin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.