Re: [PATCH 14/16] reftable/table: introduce iterator for table blocks

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 2, 2025, 07:21 UTC
Message-ID: <Z-zlfVIRRrMmHU-Y@pks.im>
In-Reply-To: <xmqq8qoja62n.fsf@gitster.g>

On Tue, Apr 01, 2025 at 03:08:00PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > +	for (size_t i = 0; i < nrecords; i++) {
> > +		records[i].value_type = REFTABLE_REF_VAL1,
> 
> -Wcomma,error

Hah, good that we've now got the warning.

> > +		records[i].refname = xstrfmt("refs/heads/branch-%03"PRIuMAX, (uintmax_t) i);
> > +	}
> 
> An overlong line.

Thanks for these two, fixed both of them locally. Will wait a bit for more reviews though before sending out a new version.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.