Re: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Oct 11, 2008, 00:44 UTC
Message-ID: <h06qyD79DtpYDO2W32USeygrtpn8V6dBogiNd6y5wtPVgMNDGwbl4A@cipher.nrlssc.navy.mil>
In-Reply-To: <20081011002431.GK8203@spearce.org>

Shawn O. Pearce wrote:

Show 16 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> wrote:
>> Since dbf5e1e9, the '--no-validate' option is a Getopt::Long boolean
>> option. The '--no-' prefix (as in --no-validate) for boolean options
>> is not supported in Getopt::Long version 2.32 which was released with
>> Perl 5.8.0. This version only supports '--no' as in '--novalidate'.
>> More recent versions of Getopt::Long, such as version 2.34, support
>> either prefix. So use the older form in the tests.
> 
> Ouch.
> 
> Should we update our docs?
> 
> Actually, if 2.32 doesn't support the --no-validate syntax than
> this is a regression in Git.  Even if it is what many would call a
> bug in Getopt::Long in Perl, I think Git 1.6.1 should still honor
> --no-validate like it did in Git 1.6.0.

If it makes any difference, none of the other boolean options would work in the documented '--no-' form either, such as --no-thread, --no-signed-off-by-cc, etc. '--no-validate' is probably the only one that used to work.

Update the docs?

---[no-]validate:: +--[no-|no]validate::

hmm. not sure.

-brandon