threads / patch / 15855

patcht9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

Subject: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

## tl;dr

3 messages between Oct 11, 2008 and Oct 11, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Brandon Casey· Oct 11, 2008, 00:21 UTC · lore

Since dbf5e1e9, the '--no-validate' option is a Getopt::Long boolean option. The '--no-' prefix (as in --no-validate) for boolean options is not supported in Getopt::Long version 2.32 which was released with Perl 5.8.0. This version only supports '--no' as in '--novalidate'. More recent versions of Getopt::Long, such as version 2.34, support either prefix. So use the older form in the tests.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t9001-send-email.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t9001-send-email.sh +1 −1

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index d098a01..561ae7d 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -109,7 +109,7 @@ test_expect_success 'allow long lines with --no-validate' '
 		--from="Example <nobody@example.com>" \
 		--to=nobody@example.com \
 		--smtp-server="$(pwd)/fake.sendmail" \
-		--no-validate \
+		--novalidate \
 		$patches longline.patch \
 		2>errors
 '

-- 
1.6.0.2.468.gd5b83

Shawn O. Pearce· Oct 11, 2008, 00:24 UTC · re: Brandon Casey · lore

Re: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

Brandon Casey <casey@nrlssc.navy.mil> wrote:

Show 6 quoted lines

> Since dbf5e1e9, the '--no-validate' option is a Getopt::Long boolean
> option. The '--no-' prefix (as in --no-validate) for boolean options
> is not supported in Getopt::Long version 2.32 which was released with
> Perl 5.8.0. This version only supports '--no' as in '--novalidate'.
> More recent versions of Getopt::Long, such as version 2.34, support
> either prefix. So use the older form in the tests.

Ouch.

Should we update our docs?

Actually, if 2.32 doesn't support the --no-validate syntax than
this is a regression in Git.  Even if it is what many would call a
bug in Getopt::Long in Perl, I think Git 1.6.1 should still honor
--no-validate like it did in Git 1.6.0.

Show 13 quoted lines

> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index d098a01..561ae7d 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -109,7 +109,7 @@ test_expect_success 'allow long lines with --no-validate' '
>  		--from="Example <nobody@example.com>" \
>  		--to=nobody@example.com \
>  		--smtp-server="$(pwd)/fake.sendmail" \
> -		--no-validate \
> +		--novalidate \
>  		$patches longline.patch \
>  		2>errors
>  '

-- 
Shawn.

Brandon Casey· Oct 11, 2008, 00:44 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

Shawn O. Pearce wrote:

Show 16 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> wrote:
>> Since dbf5e1e9, the '--no-validate' option is a Getopt::Long boolean
>> option. The '--no-' prefix (as in --no-validate) for boolean options
>> is not supported in Getopt::Long version 2.32 which was released with
>> Perl 5.8.0. This version only supports '--no' as in '--novalidate'.
>> More recent versions of Getopt::Long, such as version 2.34, support
>> either prefix. So use the older form in the tests.
> 
> Ouch.
> 
> Should we update our docs?
> 
> Actually, if 2.32 doesn't support the --no-validate syntax than
> this is a regression in Git.  Even if it is what many would call a
> bug in Getopt::Long in Perl, I think Git 1.6.1 should still honor
> --no-validate like it did in Git 1.6.0.

If it makes any difference, none of the other boolean options would work in the documented '--no-' form either, such as --no-thread, --no-signed-off-by-cc, etc. '--no-validate' is probably the only one that used to work.

Update the docs?

---[no-]validate:: +--[no-|no]validate::

hmm. not sure.

-brandon