Re: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'
Brandon Casey <casey@nrlssc.navy.mil> wrote:
Show 6 quoted lines
> Since dbf5e1e9, the '--no-validate' option is a Getopt::Long boolean
> option. The '--no-' prefix (as in --no-validate) for boolean options
> is not supported in Getopt::Long version 2.32 which was released with
> Perl 5.8.0. This version only supports '--no' as in '--novalidate'.
> More recent versions of Getopt::Long, such as version 2.34, support
> either prefix. So use the older form in the tests.
Ouch.
Should we update our docs?
Actually, if 2.32 doesn't support the --no-validate syntax than
this is a regression in Git. Even if it is what many would call a
bug in Getopt::Long in Perl, I think Git 1.6.1 should still honor
--no-validate like it did in Git 1.6.0.
Show 13 quoted lines
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index d098a01..561ae7d 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -109,7 +109,7 @@ test_expect_success 'allow long lines with --no-validate' '
> --from="Example <nobody@example.com>" \
> --to=nobody@example.com \
> --smtp-server="$(pwd)/fake.sendmail" \
> - --no-validate \
> + --novalidate \
> $patches longline.patch \
> 2>errors
> '
--
Shawn.
Shawn O. Pearce <spearce@spearce.org>