Re: [PATCH v2 4/6] reftable/stack: reorder code to avoid forward declarations

From: Justin Tobler <jltobler@gmail.com>
Date: Aug 11, 2025, 19:10 UTC
Message-ID: <gisipxu5fdge3762fddx4qyiccwdtg34a42uiv4lpevuwgmsbz@lcj7fcifogvk>
In-Reply-To: <20250804-pks-reftable-fixes-for-libgit2-v2-4-fef06209a984@pks.im>

On 25/08/04 11:40AM, Patrick Steinhardt wrote:

Show 31 quoted lines

> We have a couple of forward declarations in the stack-related code of
> the reftable library. These declarations aren't really required, but are
> simply caused by unfortunate ordering.
> 
> Reorder the code and remove the forward declarations.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  reftable/stack.c | 364 +++++++++++++++++++++++++++----------------------------
>  1 file changed, 176 insertions(+), 188 deletions(-)
> 
> diff --git a/reftable/stack.c b/reftable/stack.c
> index 3480ad21c3..d6e4ea93a3 100644
> --- a/reftable/stack.c
> +++ b/reftable/stack.c
> @@ -17,18 +17,6 @@
>  #include "table.h"
>  #include "writer.h"
>  
> -static int stack_try_add(struct reftable_stack *st,
> -			 int (*write_table)(struct reftable_writer *wr,
> -					    void *arg),
> -			 void *arg);
> -static int stack_write_compact(struct reftable_stack *st,
> -			       struct reftable_writer *wr,
> -			       size_t first, size_t last,
> -			       struct reftable_log_expiry_config *config);
> -static void reftable_addition_close(struct reftable_addition *add);
> -static int reftable_stack_reload_maybe_reuse(struct reftable_stack *st,
> -					     int reuse_open);
> -

Nice cleanup :)