Re: [PATCH v3 5/8] reftable/stack: allow passing flags to `reftable_stack_add()`

From: Justin Tobler <jltobler@gmail.com>
Date: Aug 12, 2025, 16:59 UTC
Message-ID: <dlqh2lcmz4kh7pvwwwfj2cewaqqrdnmixfwxey7u6xxqjy35yx@apdcts2rtyc4>
In-Reply-To: <20250812-pks-reftable-fixes-for-libgit2-v3-5-cf3b2267867e@pks.im>

On 25/08/12 11:54AM, Patrick Steinhardt wrote:

Show 10 quoted lines

> The `reftable_stack_add()` function is a simple wrapper to lock the
> stack, add records to it via a callback and then commit the
> result. One problem with it though is that it doesn't accept any flags
> for creating the addition. This makes it impossible to automatically
> reload the stack in case it was modified before we managed to lock the
> stack.
> 
> Add a `flags` field to plug this gap and pass it through accordingly.
> For now this new flag won't be used by us, but it will be used by
> libgit2.

It looks like we will use the new `flags` field for `reftable-stack-add()` later in the series though.

> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>