[PATCH v3 2/8] reftable/writer: drop Git-specific `QSORT()` macro
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 12, 2025, 09:54 UTC
- Message-ID
- <20250812-pks-reftable-fixes-for-libgit2-v3-2-cf3b2267867e@pks.im>
- In-Reply-To
- <20250812-pks-reftable-fixes-for-libgit2-v3-0-cf3b2267867e@pks.im>
The reftable writer accidentally uses the Git-specific `QSORT()` macro. This macro removes the need for the caller to provide the element size, but other than that it's mostly equivalent to `qsort()`.
Replace the macro accordingly to make the library usable outside of Git.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- reftable/writer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/reftable/writer.c b/reftable/writer.c index 5bad130c7e..0133b64975 100644 --- a/reftable/writer.c +++ b/reftable/writer.c @@ -399,7 +399,8 @@ int reftable_writer_add_refs(struct reftable_writer *w, { int err = 0; - QSORT(refs, n, reftable_ref_record_compare_name); + if (n) + qsort(refs, n, sizeof(*refs), reftable_ref_record_compare_name); for (size_t i = 0; err == 0 && i < n; i++) err = reftable_writer_add_ref(w, &refs[i]); @@ -491,7 +492,8 @@ int reftable_writer_add_logs(struct reftable_writer *w, { int err = 0; - QSORT(logs, n, reftable_log_record_compare_key); + if (n) + qsort(logs, n, sizeof(*logs), reftable_log_record_compare_key); for (size_t i = 0; err == 0 && i < n; i++) err = reftable_writer_add_log(w, &logs[i]);
-- 2.51.0.rc1.163.g2494970778.dirty