Re: [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE

From: René Scharfe <l.s.r@web.de>
Date: Sep 19, 2023, 07:41 UTC
Message-ID: <fff19abd-263d-48c7-81fd-35a2766b6b16@web.de>
In-Reply-To: <ZQgiD0ivfYRpSbnJ@ugly>

Am 18.09.23 um 12:10 schrieb Oswald Buddenhagen:

Show 9 quoted lines

> On Mon, Sep 18, 2023 at 11:28:31AM +0200, René Scharfe wrote:
>>
>>         return error(_("options '%s=%s' and '%s=%s' "
>>                        "cannot be used together"),
> 
>>                      "--show-current-patch", "--show-current-patch", arg, valid_modes[resume->sub_mode]);
>>
> totally on a tangent: the argument order is bogus here.
> and the line wrapping is also funny.

Hah, good catch!  Care to send a patch?

René

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.