Re: [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE
- From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
- Date
- Sep 21, 2023, 10:40 UTC
- Message-ID
- <ZQwdsfh1GQX0IOQs@ugly>
- In-Reply-To
- <f778bc6f-dbe1-4df6-95ff-c9e9f36a3cc9@web.de>
On Wed, Sep 20, 2023 at 10:18:10AM +0200, René Scharfe wrote:
> MSVC warns about all combinations. >
yes, though that's not a problem: after we established that the underlying type is int, we can just have a cast in the initializer macro.
>> so how about simply adding a (configure) test to ensure that there is >> actually no problem, and calling it a day?
> If we base it on type size then we're making assumptions that I find > hard to justify. >
the only one i can think of is signedness. i think this can be safely ignored as long as we use only small positive integers.
regards