Re: [PATCH 2/2] parse-options: use and require int pointer for OPT_CMDMODE

From: René Scharfe <l.s.r@web.de>
Date: Oct 3, 2023, 08:49 UTC
Message-ID: <d9defed8-4e7e-4b84-be3d-57155d973320@web.de>
In-Reply-To: <ZQwdsfh1GQX0IOQs@ugly>

Am 21.09.23 um 12:40 schrieb Oswald Buddenhagen:

Show 6 quoted lines

> On Wed, Sep 20, 2023 at 10:18:10AM +0200, René Scharfe wrote:
>> MSVC warns about all combinations.
>>
> yes, though that's not a problem: after we established that the
> underlying type is int, we can just have a cast in the initializer
> macro.

MSVC does some weird things in general; it's tempting to ignore it.

Show 8 quoted lines

>>> so how about simply adding a (configure) test to ensure that
>>> there is actually no problem, and calling it a day?
>
>> If we base it on type size then we're making assumptions that I
>> find hard to justify.
>>
> the only one i can think of is signedness. i think this can be safely
> ignored as long as we use only small positive integers.

I don't fully understand the pointer-sign warning, so I'm not confident enough to silence it.

René