git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 00/23] Bring more repository handles into our code base

From
Derrick Stolee <stolee@gmail.com>
Date
Nov 16, 2018, 13:15 UTC
Message-ID
<ffe3a5c3-58ff-43e3-0c35-bf68f16e928c@gmail.com>
In-Reply-To
<20181114001306.138053-1-sbeller@google.com>
On 11/13/2018 7:12 PM, Stefan Beller wrote:
> Please have a look at the last 4 patches specifically as they were new in
> the last iteration (but did not receive any comment), as they demonstrate
> and fix a problem that is only exposed when using GIT_TEST_COMMIT_GRAPH=1
> for the test suite.

I took a look at these last four and didn't find anything wrong. Rest of the series looks good.

While all of the TODOs in the last patch are an imperfect solution, I think it's probably the best we can do for now.

Thanks, -Stolee

Previous: Jonathan Tan
Message 30 of 30 in “[PATCHv3 00/23] Bring more repository handles into our code base”
  1. Stefan BellerNov 14, 2018
  2. 01/23 sha1_file: allow read_object to read objects in arbitrary repositoriesStefan Beller, Nov 14, 2018
  3. 02/23 packfile: allow has_packed_and_bad to handle arbitrary repositoriesStefan Beller, Nov 14, 2018
  4. 03/23 object-store: allow read_object_file_extended to read from any repoStefan Beller, Nov 14, 2018
  5. 04/23 object-store: prepare read_object_file to deal with any repoStefan Beller, Nov 14, 2018
  6. 05/23 object-store: prepare has_{sha1, object}_file to handle any repoStefan Beller, Nov 14, 2018
  7. 06/23 object: parse_object to honor its repository argumentStefan Beller, Nov 14, 2018
  8. 07/23 commit: allow parse_commit* to handle any repoStefan Beller, Nov 14, 2018
  9. 08/23 commit-reach.c: allow paint_down_to_common to handle any repoStefan Beller, Nov 14, 2018
  10. 09/23 commit-reach.c: allow merge_bases_many to handle any repoStefan Beller, Nov 14, 2018
  11. 10/23 commit-reach.c: allow remove_redundant to handle any repoStefan Beller, Nov 14, 2018
  12. 11/23 commit-reach.c: allow get_merge_bases_many_0 to handle any repoStefan Beller, Nov 14, 2018
  13. 12/23 commit-reach: prepare get_merge_bases to handle any repoStefan Beller, Nov 14, 2018
  14. 13/23 commit-reach: prepare in_merge_bases[_many] to handle any repoStefan Beller, Nov 14, 2018
  15. 14/23 commit: prepare get_commit_buffer to handle any repoStefan Beller, Nov 14, 2018
  16. 15/23 commit: prepare repo_unuse_commit_buffer to handle any repoStefan Beller, Nov 14, 2018
  17. 16/23 commit: prepare logmsg_reencode to handle arbitrary repositoriesStefan Beller, Nov 14, 2018
  18. 17/23 pretty: prepare format_commit_message to handle arbitrary repositoriesStefan Beller, Nov 14, 2018
  19. 18/23 submodule: use submodule repos for object lookupStefan Beller, Nov 14, 2018
  20. Jonathan TanNov 15, 2018
  21. Stefan BellerNov 15, 2018
  22. Stefan BellerDec 12, 2018
  23. submodule: correct documentation for open_submoduleStefan Beller, Dec 12, 2018
  24. 19/23 submodule: don't add submodule as odb for pushStefan Beller, Nov 14, 2018
  25. 20/23 commit-graph: convert remaining functions to handle any repoStefan Beller, Nov 14, 2018
  26. 21/23 commit: prepare free_commit_buffer and release_commit_memory for any repoStefan Beller, Nov 14, 2018
  27. 22/23 path.h: make REPO_GIT_PATH_FUNC repository agnosticStefan Beller, Nov 14, 2018
  28. 23/23 t/helper/test-repository: celebrate independence from the_repositoryStefan Beller, Nov 14, 2018
  29. Jonathan TanNov 15, 2018
  30. Derrick StoleeNov 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.