From: Derrick Stolee Date: Fri, 16 Nov 2018 13:15:26 GMT Subject: Re: [PATCHv3 00/23] Bring more repository handles into our code base Message-ID: In-Reply-To: <20181114001306.138053-1-sbeller@google.com> On 11/13/2018 7:12 PM, Stefan Beller wrote: > Please have a look at the last 4 patches specifically as they were new in > the last iteration (but did not receive any comment), as they demonstrate > and fix a problem that is only exposed when using GIT_TEST_COMMIT_GRAPH=1 > for the test suite. I took a look at these last four and didn't find anything wrong. Rest of the series looks good. While all of the TODOs in the last patch are an imperfect solution, I think it's probably the best we can do for now. Thanks, -Stolee