Re: [PATCHv3 00/23] Bring more repository handles into our code base

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 15, 2018, 22:12 UTC
Message-ID: <20181115221254.45373-1-jonathantanmy@google.com>
In-Reply-To: <20181114001306.138053-1-sbeller@google.com>

> Please have a look at the last 4 patches specifically as they were new in
> the last iteration (but did not receive any comment), as they demonstrate
> and fix a problem that is only exposed when using GIT_TEST_COMMIT_GRAPH=1
> for the test suite.

Thanks. I only reviewed patches 18 and 20-23, as only those are different from the previous iteration according to the range-diff.

I've written my comments about patch 18 already [1], and the other patches look good to me.

In patch 21, I could go either way about whether it's more desirable to pass the pool or the repository to the freeing functions.

Thanks for discovering the issue that patch 23 illustrates. I thought that the tests were written carefully enough in that the_repository didn't have any relevant objects or configurations (all relevant data was in a path that is not the default repository), but apparently some still slipped through.

[1] https://public-inbox.org/git/20181115195416.21890-1-jonathantanmy@google.com/