Re: [PATCH RESEND] send-email: add 'specify-author' option

From: Michael Witten <mfwitten@gmail.com>
Date: Apr 12, 2012, 15:36 UTC
Message-ID: <fd7f09d9f7ad4ce2a32e850c0f21cc4c-mfwitten@gmail.com>
In-Reply-To: <CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com>

On Fri, 6 Apr 2012 22:42:16 +0300, Felipe Contreras wrote:

Show 22 quoted lines

> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so
>>> while applying the patches, the author has to be fixed manually.
>>>
>>> This option allows to always specify the author of the commit in the
>>> body of the message, even if the committer is the author.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>> ---
>>
>> I wouldn't say that the existing option names to send-email are great, but
>> I have to say that the one added by this is simply horrible ;-)
>>
>> The first paragraph of the proposed commit log message states the problem
>> it tries to address very clearly, which is good, but is "From: " the only
>> thing that needs this? I am wondering if this should be named and behave
>> more like "--duplicate-header" or "--in-body-header".
>
> I have never seen any other 'in-body-header' other than From, and I
> don't see how that would be useful. Anybody else?

I sometimes like to set an explicit in-body `Date' header. However, Junio has disagreed vocally about this practice:

  Subject: Dates in Commits and other issues of style
           (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)
  Message-ID: <811b01a9-f10e-4444-9e5e-581adaf059c2-mfwitten@gmail.com>
  http://article.gmane.org/gmane.comp.version-control.git/171936

Sincerely, Michael Witten