Re: [PATCH RESEND] send-email: add 'specify-author' option

From: Michael Witten <mfwitten@gmail.com>
Date: Apr 12, 2012, 15:58 UTC
Message-ID: <87520431c0b04cd4b78aac481d81002b-mfwitten@gmail.com>
In-Reply-To: <7vobr4ze5z.fsf@alter.siamese.dyndns.org>

On Fri, 06 Apr 2012 15:30:32 -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> I can't foresee that, but I guess we can do it anyway. So which would
>> be the fields to repeat? From, Date, and Subject?
> 
> I would say From and Subject are equally worth considering.

Famous last words: "I can't foresee that."

My impression from Junio's initial comment:

>>> The first paragraph of the proposed commit log message states the problem
>>> it tries to address very clearly, which is good, but is "From: " the only
>>> thing that needs this?  I am wondering if this should be named and behave
>>> more like "--duplicate-header" or "--in-body-header".

is that a more general solution should be sought, particularly because we indeed can't foresee people's needs. I envisioned `--in-body-header' taking as an argument a colon-separated list of headers that should be inlined; let the user mix and match as he pleases, and save us trouble in the future when new headers pop up (I can't forsee that happening, but, well, who knows?).

Naturally, a configuration variable could be useful.

Sincerely, Michael Witten