git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RESEND] send-email: add 'specify-author' option

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 6, 2012, 17:14 UTC
Message-ID
<7vobr4236g.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1333714876-21895-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 8 quoted lines
> Some mail servers (Microsoft Exchange) mangle the 'From' header, so
> while applying the patches, the author has to be fixed manually.
>
> This option allows to always specify the author of the commit in the
> body of the message, even if the committer is the author.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---

I wouldn't say that the existing option names to send-email are great, but I have to say that the one added by this is simply horrible ;-)

The first paragraph of the proposed commit log message states the problem it tries to address very clearly, which is good, but is "From: " the only thing that needs this? I am wondering if this should be named and behave more like "--duplicate-header" or "--in-body-header".

Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 14 in “send-email: add 'specify-author' option”
  1. send-email: add 'specify-author' optionFelipe Contreras, Apr 6, 2012
  2. Felipe ContrerasApr 6, 2012
  3. Junio C HamanoApr 6, 2012
  4. Felipe ContrerasApr 6, 2012
  5. Junio C HamanoApr 6, 2012
  6. Felipe ContrerasApr 6, 2012
  7. Junio C HamanoApr 6, 2012
  8. Felipe ContrerasApr 7, 2012
  9. Junio C HamanoApr 8, 2012
  10. Michael WittenApr 12, 2012
  11. Michael WittenApr 12, 2012
  12. Junio C HamanoApr 12, 2012
  13. Thomas RastApr 6, 2012
  14. Felipe ContrerasApr 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.