git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/8] show_date_relative(): drop unused "tz" parameter

From
Derrick Stolee <stolee@gmail.com>
Date
Jan 24, 2019, 14:07 UTC
Message-ID
<fcbafa52-2f6d-1497-f34f-d16ea76ee7f3@gmail.com>
In-Reply-To
<20190124131221.GE22398@sigill.intra.peff.net>
On 1/24/2019 8:12 AM, Jeff King wrote:
Show 5 quoted lines
> The timestamp we receive is in epoch time, so there's no need for a
> timezone parameter to interpret it. The matching show_date() uses "tz"
> to show dates in author local time, but relative dates show only the
> absolute time difference. The author's location is irrelevant, barring
> relativistic effects from using Git close to the speed of light.
I fully support more humor in our commit messages.
-Stolee
Previous: Jeff KingNext: Jeff King
Message 7 of 13 in “drop some unused parameters”
  1. 0/9 drop some unused parametersJeff King, Jan 24, 2019
  2. 1/8 match-trees: drop unused path parameter from score functionsJeff King, Jan 24, 2019
  3. 2/8 apply: drop unused "def" parameter from find_name_gnu()Jeff King, Jan 24, 2019
  4. 3/8 create_bundle(): drop unused "header" parameterJeff King, Jan 24, 2019
  5. 4/8 column: drop unused "opts" parameter in item_length()Jeff King, Jan 24, 2019
  6. 5/8 show_date_relative(): drop unused "tz" parameterJeff King, Jan 24, 2019
  7. Derrick StoleeJan 24, 2019
  8. 6/8 config: drop unused parameter from maybe_remove_section()Jeff King, Jan 24, 2019
  9. 7/8 convert: drop len parameter from conversion checksJeff King, Jan 24, 2019
  10. 8/8 convert: drop path parameter from actual conversion functionsJeff King, Jan 24, 2019
  11. Derrick StoleeJan 24, 2019
  12. Junio C HamanoJan 24, 2019
  13. brian m. carlsonJan 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.