git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/9] drop some unused parameters

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jan 25, 2019, 01:53 UTC
Message-ID
<20190125015310.GT423984@genre.crustytoothpaste.net>
In-Reply-To
<20190124131104.GA24017@sigill.intra.peff.net>
On Thu, Jan 24, 2019 at 08:11:05AM -0500, Jeff King wrote:
Show 17 quoted lines
> I've mentioned before that I have a series which compiles cleanly with
> -Wunused-parameters. I split this work roughly into three groups:
> 
>   1. Patches that fix bugs (i.e., we should have been using the
>      parameter but didn't).
> 
>   2. Patches that drop unused parameters (i.e., code cleanup).
> 
>   3. Patches that annotate undroppable parameters (e.g., ones that are
>      present due to a callback interface).
> 
> All of the patches from group 1 have been merged already. So this series
> starts us off on group 2. There are about 50 patches in that group.
> Given that none of them are urgent, I plan to feed them in batches to
> avoid overwhelming reviewers. I'm also ordering them to avoid conflicts
> with other topics in flight (this batch has no conflicts with 'next',
> and only one minor textual conflict with 'pu').

All of these patches seemed straightforward. I did see a few where there may have originally been some consistency benefit to keeping parameters (always passing file name to *_to_worktree, for example), but I'm fine dropping them if it means we can get better development help from the compiler.

I am also, for the record, in favor of ignoring the effects of relativity for the purposes of Git. :)

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Junio C Hamano
Message 13 of 13 in “drop some unused parameters”
  1. 0/9 drop some unused parametersJeff King, Jan 24, 2019
  2. 1/8 match-trees: drop unused path parameter from score functionsJeff King, Jan 24, 2019
  3. 2/8 apply: drop unused "def" parameter from find_name_gnu()Jeff King, Jan 24, 2019
  4. 3/8 create_bundle(): drop unused "header" parameterJeff King, Jan 24, 2019
  5. 4/8 column: drop unused "opts" parameter in item_length()Jeff King, Jan 24, 2019
  6. 5/8 show_date_relative(): drop unused "tz" parameterJeff King, Jan 24, 2019
  7. Derrick StoleeJan 24, 2019
  8. 6/8 config: drop unused parameter from maybe_remove_section()Jeff King, Jan 24, 2019
  9. 7/8 convert: drop len parameter from conversion checksJeff King, Jan 24, 2019
  10. 8/8 convert: drop path parameter from actual conversion functionsJeff King, Jan 24, 2019
  11. Derrick StoleeJan 24, 2019
  12. Junio C HamanoJan 24, 2019
  13. brian m. carlsonJan 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.