git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/8] column: drop unused "opts" parameter in item_length()

From
Jeff King <peff@peff.net>
Date
Jan 24, 2019, 13:11 UTC
Message-ID
<20190124131158.GD22398@sigill.intra.peff.net>
In-Reply-To
<20190124131104.GA24017@sigill.intra.peff.net>

There are no column options which impact the length computation. In theory there might be, but this is a file-local function, so it will be trivial to re-add the parameter should it ever be useful.

Signed-off-by: Jeff King <peff@peff.net>
---
 column.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/column.c b/column.c
index 2165297608..7a17c14b82 100644
--- a/column.c
+++ b/column.c
@@ -21,7 +21,7 @@ struct column_data {
 };
 
 /* return length of 's' in letters, ANSI escapes stripped */
-static int item_length(unsigned int colopts, const char *s)
+static int item_length(const char *s)
 {
 	int len, i = 0;
 	struct strbuf str = STRBUF_INIT;
@@ -167,7 +167,7 @@ static void display_table(const struct string_list *list,
 
 	ALLOC_ARRAY(data.len, list->nr);
 	for (i = 0; i < list->nr; i++)
-		data.len[i] = item_length(colopts, list->items[i].string);
+		data.len[i] = item_length(list->items[i].string);
 
 	layout(&data, &initial_width);
 
-- 
2.20.1.842.g8986705066
Previous: Jeff KingNext: Jeff King
Message 5 of 13 in “drop some unused parameters”
  1. 0/9 drop some unused parametersJeff King, Jan 24, 2019
  2. 1/8 match-trees: drop unused path parameter from score functionsJeff King, Jan 24, 2019
  3. 2/8 apply: drop unused "def" parameter from find_name_gnu()Jeff King, Jan 24, 2019
  4. 3/8 create_bundle(): drop unused "header" parameterJeff King, Jan 24, 2019
  5. 4/8 column: drop unused "opts" parameter in item_length()Jeff King, Jan 24, 2019
  6. 5/8 show_date_relative(): drop unused "tz" parameterJeff King, Jan 24, 2019
  7. Derrick StoleeJan 24, 2019
  8. 6/8 config: drop unused parameter from maybe_remove_section()Jeff King, Jan 24, 2019
  9. 7/8 convert: drop len parameter from conversion checksJeff King, Jan 24, 2019
  10. 8/8 convert: drop path parameter from actual conversion functionsJeff King, Jan 24, 2019
  11. Derrick StoleeJan 24, 2019
  12. Junio C HamanoJan 24, 2019
  13. brian m. carlsonJan 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.