Re: submodules' shortcomings, was Re: RFC: display dirty submodule working directory in git gui and gitk

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jan 6, 2010, 17:23 UTC
Message-ID: <fcaeb9bf1001060923m6559f00bp794bb5fdd4af704c@mail.gmail.com>
In-Reply-To: <7vbph7181x.fsf@alter.siamese.dyndns.org>

On 1/7/10, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>
> > Am 06.01.2010 02:04, schrieb Junio C Hamano:
>  >> After all we _were_ in agreement.  We both think the user should be told
>  >> about untracked files in submodule directory when inspecting the status to
>  >> make a commit in the superproject.
>  >
>  > Thanks. So i'll take a closer look at the diff core (but i suspect i'll
>  > need some time until i can come up with some patches because i don't know
>  > this part of git very well).
>
>
> I don't see a direct connection between "the user should be told about
>  untracked in the submodule before committing" and diffcore.  It is just
>  the matter of "git status" and "git commit" running another instance of
>  "git status" via run_command() interface in the submodule directory, no?

You would need to rewrite file paths so that files in submodules are also relative to the same directory as files in supermodule (I tried to do that with GIT_WORK_TREE and needed to change a bit). Or you could show each "git status" output separately, which does not look as nice as the former in my opinion.

-- 
Duy