git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: remove xargs in favor of --stdin where possible

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Apr 23, 2009, 23:22 UTC
Message-ID
<fcaeb9bf0904231622x721483f2v9f009784509676b@mail.gmail.com>
In-Reply-To
<7v8wlrwtt3.fsf@gitster.siamese.dyndns.org>
On Thu, Apr 23, 2009 at 8:25 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>>> The tests may not break with your change because none of them may use
>>> problematic characters (especially "\n" and '"'), but update-index --stdin
>>> without -z is not suitable for reading from output from "find" without -0
>>> option (on the other hand, "update-index -z --stdin" is good for reading
>>> output from "find -0"; but for portability we avoid GNUism "find -0").
>>
>> It can't be as safe as find -0| update-index -z, but it would be
>> equivalent to find|xargs, isn't it? Both separate arguments by \n.
>
> Have you worked with pathnames with high-bit set and without
> core.quotepath set to false?

OK I see. There are some fancy unquoting going on inside. I'd take the patch back.

-- 
Duy
Previous: Junio C Hamano
Message 6 of 6 in “tests: remove xargs in favor of --stdin where possible”
  1. tests: remove xargs in favor of --stdin where possibleNguyễn Thái Ngọc Duy, Apr 23, 2009
  2. Junio C HamanoApr 23, 2009
  3. Johannes SixtApr 23, 2009
  4. Nguyen Thai Ngoc DuyApr 23, 2009
  5. Junio C HamanoApr 23, 2009
  6. Nguyen Thai Ngoc DuyApr 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.