From: Nguyen Thai Ngoc Duy Date: Thu, 23 Apr 2009 23:22:10 GMT Subject: Re: [PATCH] tests: remove xargs in favor of --stdin where possible Message-ID: In-Reply-To: <7v8wlrwtt3.fsf@gitster.siamese.dyndns.org> On Thu, Apr 23, 2009 at 8:25 PM, Junio C Hamano wrote: > Nguyen Thai Ngoc Duy writes: > >>> The tests may not break with your change because none of them may use >>> problematic characters (especially "\n" and '"'), but update-index --stdin >>> without -z is not suitable for reading from output from "find" without -0 >>> option (on the other hand, "update-index -z --stdin" is good for reading >>> output from "find -0"; but for portability we avoid GNUism "find -0"). >> >> It can't be as safe as find -0| update-index -z, but it would be >> equivalent to find|xargs, isn't it? Both separate arguments by \n. > > Have you worked with pathnames with high-bit set and without > core.quotepath set to false? OK I see. There are some fancy unquoting going on inside. I'd take the patch back. -- Duy