Re: [PATCH] tests: remove xargs in favor of --stdin where possible
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Apr 23, 2009, 10:07 UTC
- Message-ID
- <fcaeb9bf0904230307h2d4ee691y412e9cf31e4e90c3@mail.gmail.com>
- In-Reply-To
- <7vfxfzwytx.fsf@gitster.siamese.dyndns.org>
2009/4/23 Junio C Hamano <gitster@pobox.com>:
Show 14 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> >> --- >> Patch "Convert to use quiet option when available" reminds me I had a similar >> patch to remove (mostly) xargs usage from tests. > > The reason being...? > > (1) xargs is not universally available, or portable enough? > > (2) people may learn from tests, and we should demostrate our ability? > > (3) something else?
I worked on busybox win32 port, less commands meant less work for me. So (1).
Show 5 quoted lines
> The tests may not break with your change because none of them may use > problematic characters (especially "\n" and '"'), but update-index --stdin > without -z is not suitable for reading from output from "find" without -0 > option (on the other hand, "update-index -z --stdin" is good for reading > output from "find -0"; but for portability we avoid GNUism "find -0").
It can't be as safe as find -0| update-index -z, but it would be equivalent to find|xargs, isn't it? Both separate arguments by \n.
-- Duy