Re: [PATCH] rehabilitate 'git index-pack' inside the object store
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Oct 22, 2008, 14:57 UTC
- Message-ID
- <fcaeb9bf0810220757w678e303cl6237eb8908261cba@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0810211856090.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On 10/22/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 9 quoted lines
> So I propose this change in semantics: > > - setup_git_directory_gently(): rename to discover_git_directory(), > and avoid any chdir() at all. > - setup_git_directory(): keep the semantics that it chdir()s to the > worktree, or to the git directory for bare repositories. > > Using _gently() even for RUN_SETUP builtins should solve the long standing > pager problem, too.
Also, from [1] may be only set default git_dir in setup_git_env() after setup_git_directory() has been called and before setup_work_tree() is called (if any)? If not, die().
[1] http://article.gmane.org/gmane.comp.version-control.git/98849
-- Duy