git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rehabilitate 'git index-pack' inside the object store

From
Jeff King <peff@peff.net>
Date
Oct 21, 2008, 17:43 UTC
Message-ID
<20081021174303.GA25827@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0810211856090.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On Tue, Oct 21, 2008 at 07:02:48PM +0200, Johannes Schindelin wrote:
Show 9 quoted lines
> So I propose this change in semantics:
> 
> - setup_git_directory_gently(): rename to discover_git_directory(), 
>   and avoid any chdir() at all.
> - setup_git_directory(): keep the semantics that it chdir()s to the
>   worktree, or to the git directory for bare repositories.
> 
> Using _gently() even for RUN_SETUP builtins should solve the long standing 
> pager problem, too.

I'm not sure there aren't hidden problems lurking in that strategy (every time I look at this area of code, something unexpected prevents what I think should Just Work from Just Working), but I think that is a promising direction to go for clearing up some of the long-standing issues.

I think you will need to do something for a few commands which use _gently() but then, if we _are_ in a git repo, assume we are chdir'd properly.

We may also be able to just call setup_git_directory_gently() as the first thing in the wrapper, which should help us more consistently find config before the 'exec' stage (see 4e10738a for a discussion of some of the issues).

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 7 of 11 in “rehabilitate 'git index-pack' inside the object store”
  1. rehabilitate 'git index-pack' inside the object storeNicolas Pitre, Oct 21, 2008
  2. (squash) add index-pack with git-dir testJunio C Hamano, Oct 21, 2008
  3. Nguyen Thai Ngoc DuyOct 21, 2008
  4. Jeff KingOct 21, 2008
  5. Nicolas PitreOct 21, 2008
  6. Johannes SchindelinOct 21, 2008
  7. Jeff KingOct 21, 2008
  8. new plan for cleaning up the worktree mess, was Re: [PATCH] rehabilitate 'git index-pack' inside the object storeJohannes Schindelin, Oct 21, 2008
  9. Nguyen Thai Ngoc DuyOct 28, 2008
  10. Nguyen Thai Ngoc DuyOct 22, 2008
  11. Nguyen Thai Ngoc DuyOct 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.