git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rehabilitate 'git index-pack' inside the object store

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 21, 2008, 17:02 UTC
Message-ID
<alpine.DEB.1.00.0810211856090.22125@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To
<fcaeb9bf0810210757w1c14e0a3x1eb61a589a089f10@mail.gmail.com>
Hi,
On Tue, 21 Oct 2008, Nguyen Thai Ngoc Duy wrote:
> Maybe we should let setup_*_gently() do read-only stuff only and let its 
> consumers to handle cwd.

I think that makes sense. This would allow setup*gently() to be much cleaner, and only setup_git_directory() itself would do the chdir(worktree).

However, let's think this really through this time, so that that darned worktree stuff is fixed for good.

So I propose this change in semantics:
- setup_git_directory_gently(): rename to discover_git_directory(), 
  and avoid any chdir() at all.
- setup_git_directory(): keep the semantics that it chdir()s to the
  worktree, or to the git directory for bare repositories.

Using _gently() even for RUN_SETUP builtins should solve the long standing pager problem, too.

Ciao, Dscho

Previous: Nicolas PitreNext: Jeff King
Message 6 of 11 in “rehabilitate 'git index-pack' inside the object store”
  1. rehabilitate 'git index-pack' inside the object storeNicolas Pitre, Oct 21, 2008
  2. (squash) add index-pack with git-dir testJunio C Hamano, Oct 21, 2008
  3. Nguyen Thai Ngoc DuyOct 21, 2008
  4. Jeff KingOct 21, 2008
  5. Nicolas PitreOct 21, 2008
  6. Johannes SchindelinOct 21, 2008
  7. Jeff KingOct 21, 2008
  8. new plan for cleaning up the worktree mess, was Re: [PATCH] rehabilitate 'git index-pack' inside the object storeJohannes Schindelin, Oct 21, 2008
  9. Nguyen Thai Ngoc DuyOct 28, 2008
  10. Nguyen Thai Ngoc DuyOct 22, 2008
  11. Nguyen Thai Ngoc DuyOct 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.