git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: handle NO_PYTHON setting

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Nov 30, 2009, 09:56 UTC
Message-ID
<fabb9a1e0911300156l7f8dbe55p7da26540b0360773@mail.gmail.com>
In-Reply-To
<7vr5rgv1lr.fsf@alter.siamese.dyndns.org>
Heya,
On Mon, Nov 30, 2009 at 09:49, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> Sorry, I don't understand that.  With that reasoning, isn't having a
> single git package, be it python or not, even easier?  Why would anybody
> want a separate egg that includes everything that _happen_ to be written
> in Python in the first place?  It doesn't make sense at all from packaging
> point of view to me.

Because that's the recommended way to create a python package, create a new directory, put the files in it, and distribute it.

Show 8 quoted lines
> A separate egg per remote-helper that you can pick and choose which ones
> to install and which ones to leave out would make perfect sense, exactly
> the same way that distros already split git into "git-core", "git-svn",
> etc., though.  Your "git-hg" may consist of a single egg and perhaps some
> other supporting code, and people who want to convert away from legacy Hg
> repository may want to install it, but it is entirely up to them if they
> also want to install "git-cvs" that is implemented as a remote-helper that
> happens to be written in Python, no?

Yes, fair enough, but we don't do that for any other files in git.git. The packagers do so, sure, but a different concern. The reason we want to distribute the git_remote_helpers package is so that git-remote-hg.py, which lives in git.git/ and is installed as git-remote-hg can say "from git_remote_helpers.hg import export".

The only reason this is needed in the first place is because we can't just add the python files to libgit.a or embed it in git-remote-hg statically, python does not support that. That is the only reason we need to distribute the package, which is why we need a separate directory.

That is, if I've understood Johan's reasoning and intention correctly.
-- 
Cheers,

Sverre Rabbelier
Previous: Junio C HamanoNext: Johan Herland
Message 9 of 16 in “tests: handle NO_PYTHON setting”
  1. tests: handle NO_PYTHON settingJeff King, Nov 30, 2009
  2. Sverre RabbelierNov 30, 2009
  3. Jeff KingNov 30, 2009
  4. Sverre RabbelierNov 30, 2009
  5. Jeff KingNov 30, 2009
  6. Junio C HamanoNov 30, 2009
  7. Sverre RabbelierNov 30, 2009
  8. Junio C HamanoNov 30, 2009
  9. Sverre RabbelierNov 30, 2009
  10. Johan HerlandNov 30, 2009
  11. Junio C HamanoNov 30, 2009
  12. Johan HerlandNov 30, 2009
  13. Brandon CaseyNov 30, 2009
  14. Jeff KingNov 30, 2009
  15. Brandon CaseyNov 30, 2009
  16. Johan HerlandNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.