git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: handle NO_PYTHON setting

From
Jeff King <peff@peff.net>
Date
Nov 30, 2009, 07:59 UTC
Message-ID
<20091130075927.GA5767@coredump.intra.peff.net>
In-Reply-To
<fabb9a1e0911292355v260b9f0ck79d993e25f0c5c61@mail.gmail.com>
On Mon, Nov 30, 2009 at 08:55:51AM +0100, Sverre Rabbelier wrote:
Show 9 quoted lines
> > This feels a little funny for NO_PYTHON to mean "no remote helpers at
> > all". But that is the way the Makefile is set up, since we seem to have
> > only python helpers.
> 
> I don't understand what you mean? Do you mean NO_PYTHON implies "no
> remote helpers at all", or "not having any remote helpers" implies
> NO_PYTHON? Either way, I'm not sure how to set it up differently, not
> having that much Makefile foo myself, so maybe Johan and Daniel could
> comment?

I mean, I would think that the "git_remote_helpers" directory contained remote helpers of all sorts, not just the python ones. Right now we _only_ have python ones. So checking for NO_PYTHON in test-lib.sh before looking at git_remote_helpers makes sense. But I am concerned that assumption will be broken silently in the future if non-python helpers are added to git_remote_helpers.

It is probably not worth caring about too much, though.
-Peff
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 3 of 16 in “tests: handle NO_PYTHON setting”
  1. tests: handle NO_PYTHON settingJeff King, Nov 30, 2009
  2. Sverre RabbelierNov 30, 2009
  3. Jeff KingNov 30, 2009
  4. Sverre RabbelierNov 30, 2009
  5. Jeff KingNov 30, 2009
  6. Junio C HamanoNov 30, 2009
  7. Sverre RabbelierNov 30, 2009
  8. Junio C HamanoNov 30, 2009
  9. Sverre RabbelierNov 30, 2009
  10. Johan HerlandNov 30, 2009
  11. Junio C HamanoNov 30, 2009
  12. Johan HerlandNov 30, 2009
  13. Brandon CaseyNov 30, 2009
  14. Jeff KingNov 30, 2009
  15. Brandon CaseyNov 30, 2009
  16. Johan HerlandNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.