Re: [PATCH] blame: make sure that the last line ends in an LF

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 22, 2009, 01:33 UTC
Message-ID: <fabb9a1e0910211833qb1315aan89f43a7b5b51c556@mail.gmail.com>
In-Reply-To: <7viqe9n72w.fsf@alter.siamese.dyndns.org>

Heya,

On Tue, Oct 20, 2009 at 15:28, Junio C Hamano <gitster@pobox.com> wrote:

> For both styles of output, adding an extra LF after "no newline" would be
> necessary to make the output legible (for human) and parsable (for
> scripts).

You mean like this right?

```
+               printf("\n\\ No newline at end of file\n");
```

Or does it need _another_ newline, like this

```
+               printf("\n\\ No newline at end of file\n\n");
```

Show 5 quoted lines

> In addition, it would help Porcelains to re-construct the final text if
> you added a boolean "incomplete-line" (put it on its own line, immediately
> after "filename test" line).  Then they will know that LF after "second
> line, no newline" was not there in the original and was added for
> parsability.

What do we do in the case that the last few lines are attributed to the same commit? Do we just signify 'incomplete line' to mean that the last one of those is incomplete?

> I am not sure what we want to do for non-porcelain output (other than
> adding the extra LF at the end).  Assuming that they are meant to be read
> by humans (and casual scripts that do not bother reading --porcelain
> format), it might be best not to add any extra marking.

Fine by me :).

-- 
Cheers,

Sverre Rabbelier