Re: [PATCH] blame: make sure that the last line ends in an LF

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 20, 2009, 19:55 UTC
Message-ID: <alpine.DEB.1.00.0910202153160.4985@pacific.mpi-cbg.de>
In-Reply-To: <7vbpk2ovio.fsf@alter.siamese.dyndns.org>

Hi,

On Tue, 20 Oct 2009, Junio C Hamano wrote:

Show 13 quoted lines

> Sverre Rabbelier <srabbelier@gmail.com> writes:
> 
> >> Or am I worrying too much?
> >
> > No, I think your concerns are valid, we should go with (2) and DTRT. 
> > Does the updated patch address your concerns? If so I can send a new 
> > version.
> 
> Assuming the internal blame algorithm correctly works with such an 
> input, I'd be happier with an approach to allow users to tell the 
> difference. The --porcelain output was designed to be extensible, and it 
> might make sense to show the "this line is incomplete" as a separate 
> bit, though.

Sorry, you lost me. If, say, line 614 is the last line that does not end in a new line, if I ask for it to be blamed, I want to know who is responsible for the current form of line 614.

Not whether the line ends in a new line or not.

Ciao, Dscho