git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] blame: make sure that the last line ends in an LF

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Oct 20, 2009, 03:06 UTC
Message-ID
<1256007988-13321-1-git-send-email-srabbelier@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

This is convenient when parsing multiple the blame of multiple files, for example:

    git ls-files -z --exclude-standard -- "*.[ch]" |
    xargs --null -n 1 git blame -p > output
and then analyzing the 'output' file using a seperate script.

Currently the parsing is difficult when not all files have a newline at EOF, this patch ensures that even such files have a newline at the end of the blame output.

Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
CC: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    Patch by Dscho, commit message by me. Apologies to Dscho for
    taking so long to send it :).
 builtin-blame.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/builtin-blame.c b/builtin-blame.c
index 7512773..dd16b22 100644
--- a/builtin-blame.c
+++ b/builtin-blame.c
@@ -1604,6 +1604,9 @@ static void emit_porcelain(struct scoreboard *sb, struct blame_entry *ent)
 		} while (ch != '\n' &&
 			 cp < sb->final_buf + sb->final_buf_size);
 	}
+
+	if (sb->final_buf_size && cp[-1] != '\n')
+		putchar('\n');
 }
 
 static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
@@ -1667,6 +1670,9 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
 		} while (ch != '\n' &&
 			 cp < sb->final_buf + sb->final_buf_size);
 	}
+
+	if (sb->final_buf_size && cp[-1] != '\n')
+		putchar('\n');
 }
 
 static void output(struct scoreboard *sb, int option)
-- 
1.6.5.1.123.ge01f7
Next: Junio C Hamano
Message 1 of 9 in “blame: make sure that the last line ends in an LF”
  1. blame: make sure that the last line ends in an LFSverre Rabbelier, Oct 20, 2009
  2. Junio C HamanoOct 20, 2009
  3. Sverre RabbelierOct 20, 2009
  4. Junio C HamanoOct 20, 2009
  5. Johannes SchindelinOct 20, 2009
  6. Junio C HamanoOct 20, 2009
  7. Sverre RabbelierOct 20, 2009
  8. Junio C HamanoOct 20, 2009
  9. Sverre RabbelierOct 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.