git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] fast-import: define a new option command

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Aug 13, 2009, 22:01 UTC
Message-ID
<fabb9a1e0908131501o73807f81mb230530c284ad123@mail.gmail.com>
In-Reply-To
<alpine.DEB.1.00.0908132350190.8306@pacific.mpi-cbg.de>
Heya,

On Thu, Aug 13, 2009 at 14:51, Johannes Schindelin<Johannes.Schindelin@gmx.de> wrote:

Show 5 quoted lines
> Sorry if I spoil the party, but maybe if things get so complicated, it may
> be a sign that the original version (stream overrides command line, since
> it knows better) is to be preferred?  After all, if hg fast-export says
> that the marks should be imported from a certain file, it may be for a
> _very good_ reason...

Yes, and that should Just Work (which it does). Also, I'm not sure how often one would output a stream on one computer, then move it to another and import it there, but I'll methinks Shawn brought it up for a reason ;). However, I do think it's better design to only store the name of the import file and then do the actual import later on (to prevent double imports).

I don't have a preference either way (both patches are already written after all). Shawn?

-- 
Cheers,

Sverre Rabbelier
Previous: Johannes SchindelinNext: Shawn O. Pearce
Message 22 of 30 in “fast-import: add a new option command”
  1. 0/4 fast-import: add a new option commandSverre Rabbelier, Aug 13, 2009
  2. 1/4 fast-import: put option parsing code in seperate functionsSverre Rabbelier, Aug 13, 2009
  3. 2/4 fast-import: define a new option commandSverre Rabbelier, Aug 13, 2009
  4. 3/4 fast-import: add option commandSverre Rabbelier, Aug 13, 2009
  5. 4/4 fast-import: test the new option commandSverre Rabbelier, Aug 13, 2009
  6. Shawn O. PearceAug 13, 2009
  7. Shawn O. PearceAug 13, 2009
  8. Johannes SchindelinAug 13, 2009
  9. Shawn O. PearceAug 13, 2009
  10. Johannes SchindelinAug 13, 2009
  11. Shawn O. PearceAug 13, 2009
  12. Shawn O. PearceAug 13, 2009
  13. Sverre RabbelierAug 13, 2009
  14. Johannes SchindelinAug 13, 2009
  15. Sverre RabbelierAug 13, 2009
  16. Shawn O. PearceAug 13, 2009
  17. Sverre RabbelierAug 13, 2009
  18. Shawn O. PearceAug 13, 2009
  19. Sverre RabbelierAug 13, 2009
  20. Shawn O. PearceAug 13, 2009
  21. Johannes SchindelinAug 13, 2009
  22. Sverre RabbelierAug 13, 2009
  23. Shawn O. PearceAug 13, 2009
  24. Sverre RabbelierAug 13, 2009
  25. Junio C HamanoAug 13, 2009
  26. Sverre RabbelierAug 13, 2009
  27. Junio C HamanoAug 13, 2009
  28. Sverre RabbelierAug 13, 2009
  29. Sverre RabbelierNov 23, 2009
  30. Shawn O. PearceNov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.