Re: [PATCH 2/4] fast-import: define a new option command

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 13, 2009, 17:25 UTC
Message-ID: <20090813172508.GO1033@spearce.org>
In-Reply-To: <fabb9a1e0908131009j51c54cacp3f837f9b8525061@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> wrote:

Show 6 quoted lines

> On Thu, Aug 13, 2009 at 10:07, Johannes
> Schindelin<Johannes.Schindelin@gmx.de> wrote:
> > ... and will import the marks twice?
> 
> Ah, you're right :(. What's the best way to do this? Should we dump
> any previous marks when importing new ones?

Uh, well, yes. We shouldn't define :5 if it was in the file that appeared in the stream, but isn't in the file on the command line.

Worse, what happens if we do this:

  echo "option import-marks=/not/found" \
  | git fast-import --import-marks=my.marks

I want this to work, even though /not/found does not exist, but my.marks does. So that does complicate things...

-- 
Shawn.