Re: [PATCH 2/4] fast-import: define a new option command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 13, 2009, 14:56 UTC
Message-ID: <alpine.DEB.1.00.0908131652190.7429@intel-tinevez-2-302>
In-Reply-To: <20090813144327.GK1033@spearce.org>

Hi,

On Thu, 13 Aug 2009, Shawn O. Pearce wrote:

Show 12 quoted lines

> Sverre Rabbelier <srabbelier@gmail.com> wrote:
>
> > +Note that options specified by the frontend override any options the
> > +user may specify to git fast-import itself.
> 
> Hmmph.  Do we really want that?  I would think the command line options 
> should override the stream, such that we can then do something like:
> 
>   hg fast-export >foo
>   git fast-import --export-marks=mymarks <foo
> 
> even though 'option export-marks=bar' appears in foo.

I guess the reason is that this is harder to implement. The problem is that you _have_ to parse the command line options first. So you need to record with every option you set that it has been set by the command line, and must not be overridden by the in-stream options.

OTOH,

	hg fast-export |
	sed '1,/^blob/s/^option export-marks=.*$//' > foo

is relatively easy.

Ciao, Dscho