git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] diff-format.txt: fix ancient copy-paste error

From
Philippe Blain <levraiphilippeblain@gmail.com>
Date
Jun 14, 2022, 12:20 UTC
Message-ID
<f6e86c07-0c70-3837-abb2-874d599359b8@gmail.com>
In-Reply-To
<xmqq35g8772x.fsf@gitster.g>
Hi Junio,
Le 2022-06-13 à 14:26, Junio C Hamano a écrit :
Show 22 quoted lines
> "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> Fix what is probably a copy-paste error dating back all the way to
>> b6d8f309d9 ([PATCH] diff-raw format update take #2., 2005-05-23).
> 
> I'll retitle and rewrite the message like so:
> 
>     diff-format.txt: dst can be 0* SHA-1 when path is deleted, too
>     
>     "dst" can legitimately be "0\{40\}" for a creation patch, e.g. when
>     the stat information is stale, but it falls into "look at work tree"
>     case.  The original description in b6d8f309 ([PATCH] diff-raw format
>     update take #2., 2005-05-23) forgot that deletion also makes the
>     "dst" 0* SHA-1.
>     
>     Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Thanks.
> 

OK, that makes sense. I hadn't thought of the case you are mentioning here (new file added to the index and then modified).

Thanks,
Philippe.
Previous: Junio C HamanoNext: Philippe Blain via GitGitGadget
Message 5 of 11 in “Fix a few documentation errors around the raw diff output”
  1. 0/3 Fix a few documentation errors around the raw diff outputPhilippe Blain via GitGitGadget, Jun 13, 2022
  2. 1/3 diff-format.txt: fix ancient copy-paste errorPhilippe Blain via GitGitGadget, Jun 13, 2022
  3. Junio C HamanoJun 13, 2022
  4. Junio C HamanoJun 13, 2022
  5. Philippe BlainJun 14, 2022
  6. 2/3 diff-format.txt: correct misleading wordingPhilippe Blain via GitGitGadget, Jun 13, 2022
  7. Junio C HamanoJun 13, 2022
  8. Philippe BlainJun 14, 2022
  9. 3/3 diff-index.txt: update raw output format in examplesPhilippe Blain via GitGitGadget, Jun 13, 2022
  10. Junio C HamanoJun 13, 2022
  11. Junio C HamanoJun 13, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.