Re: [PATCH 1/3] diff-format.txt: fix ancient copy-paste error

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2022, 18:26 UTC
Message-ID: <xmqq35g8772x.fsf@gitster.g>
In-Reply-To: <6eaf9b3829fa8f7300bc0123c916d5ffa7c7d80b.1655123383.git.gitgitgadget@gmail.com>

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> Fix what is probably a copy-paste error dating back all the way to
> b6d8f309d9 ([PATCH] diff-raw format update take #2., 2005-05-23).

I'll retitle and rewrite the message like so:

    diff-format.txt: dst can be 0* SHA-1 when path is deleted, too
    
    "dst" can legitimately be "0\{40\}" for a creation patch, e.g. when
    the stat information is stale, but it falls into "look at work tree"
    case.  The original description in b6d8f309 ([PATCH] diff-raw format
    update take #2., 2005-05-23) forgot that deletion also makes the
    "dst" 0* SHA-1.
    
    Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

Thanks.