From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Tue, 14 Jun 2022 12:20:57 GMT
Subject: Re: [PATCH 1/3] diff-format.txt: fix ancient copy-paste error
Message-ID: <f6e86c07-0c70-3837-abb2-874d599359b8@gmail.com>
In-Reply-To: <xmqq35g8772x.fsf@gitster.g>

Hi Junio,

Le 2022-06-13 à 14:26, Junio C Hamano a écrit :
> "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> Fix what is probably a copy-paste error dating back all the way to
>> b6d8f309d9 ([PATCH] diff-raw format update take #2., 2005-05-23).
> 
> I'll retitle and rewrite the message like so:
> 
>     diff-format.txt: dst can be 0* SHA-1 when path is deleted, too
>     
>     "dst" can legitimately be "0\{40\}" for a creation patch, e.g. when
>     the stat information is stale, but it falls into "look at work tree"
>     case.  The original description in b6d8f309 ([PATCH] diff-raw format
>     update take #2., 2005-05-23) forgot that deletion also makes the
>     "dst" 0* SHA-1.
>     
>     Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Thanks.
> 

OK, that makes sense. I hadn't thought of the case you are mentioning here
(new file added to the index and then modified).

Thanks,

Philippe.