Re: [PATCH 01/10] name-rev: rewrite create_or_update_name()

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 5, 2020, 02:00 UTC
Message-ID: <f0e0ab6c-afde-307e-bbf0-823c576d67ca@gmail.com>
In-Reply-To: <b8f6a47e-1cbe-b2c7-cdde-ff2dc28af2b2@web.de>

On 2/4/2020 4:14 PM, René Scharfe wrote:

Show 7 quoted lines

> This code was moved straight out of name_rev(). As such, we inherited
> the "goto" to jump from an if into an else-if. We also inherited the
> fact that "nothing to do -- return NULL" is handled last.
> 
> Rewrite the function to first handle the "nothing to do" case. Then we
> can handle the conditional allocation early before going on to populate
> the struct. No need for goto-ing.

I read this carefully and agree it is functionally equivalent.

Since you are removing a goto and rearranging if/else blocks, I thought this response needed to be explicit, at least more than usual. Good work.

Thanks, -Stolee