Re: [PATCH 01/10] name-rev: rewrite create_or_update_name()

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 5, 2020, 02:35 UTC
Message-ID: <20200205023506.GA58070@syl.local>
In-Reply-To: <f0e0ab6c-afde-307e-bbf0-823c576d67ca@gmail.com>

On Tue, Feb 04, 2020 at 09:00:23PM -0500, Derrick Stolee wrote:

Show 10 quoted lines

> On 2/4/2020 4:14 PM, René Scharfe wrote:
> > This code was moved straight out of name_rev(). As such, we inherited
> > the "goto" to jump from an if into an else-if. We also inherited the
> > fact that "nothing to do -- return NULL" is handled last.
> >
> > Rewrite the function to first handle the "nothing to do" case. Then we
> > can handle the conditional allocation early before going on to populate
> > the struct. No need for goto-ing.
>
> I read this carefully and agree it is functionally equivalent.

As did I. I originally thought that my MUA was wrapping the 'else if' line oddly, but then I discovered that it's the label's indentation that was throwing me off.

In any case, this makes good sense. Well done indeed.

Show 5 quoted lines

> Since you are removing a goto and rearranging if/else blocks, I thought
> this response needed to be explicit, at least more than usual. Good work.
>
> Thanks,
> -Stolee

Thanks, Taylor