Re: [PATCH 00/10] name-rev: improve memory usage
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Feb 5, 2020, 15:20 UTC
- Message-ID
- <d4815a14-eb7e-ae9e-54fe-ebfcdde70128@gmail.com>
- In-Reply-To
- <06f8c44c-66aa-d9d5-7653-436424f5c864@gmail.com>
On 2/4/2020 10:28 PM, Derrick Stolee wrote:
Show 15 quoted lines
> On 2/4/2020 4:12 PM, René Scharfe wrote: >> This series seeks to get reduce the size of memory allocations, the >> number of reallocations and the amount of leaks in git name-rev, to >> improve its performance. > > I am generally very happy with the performance benefits and think > this series is very well organized. > >> name-rev: don't leak path copy in name_ref() >> name-rev: generate name strings only if they are better >> name-rev: release unused name strings > > I don't have the right context to understand these patches without > applying them and investigating the methods around the changes. > They intrigue me, though, so I plan to pick this up again tomorrow.
After looking closely at these three, they LGTM.
Thanks, -Stolee