Re: [PATCH 1/2] Sanitize for_each_reflog_ent()

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 9, 2007, 00:15 UTC
Message-ID: <enumq8$oa$1@sea.gmane.org>
In-Reply-To: <Pine.LNX.4.63.0701081316110.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin wrote:

Show 14 quoted lines

> On Sun, 7 Jan 2007, Junio C Hamano wrote:
> 
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>>> Further, it makes no sense to force the parsing upon the helper
>>> functions; for_each_reflog_ent() now calls the helper function with
>>> old and new sha1, the email, the timestamp & timezone, and the message.
>> 
>> Perhaps.  I did it that way deliberately because all existing
>> users did not have to pay overhead of parsing.
> 
> My reasoning is that invalid entries should rather be ignored than be 
> taken into account. So, to verify that you are not walking invalid data, 
> you have to parse it anyway.

I think that Junio was talking about the fact, that if you for example do need only refname and sha1, there is no need to parse object at all. If you don't need to, don't parse.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git