Re: [PATCH 1/2] Sanitize for_each_reflog_ent()

From

Junio C Hamano <junkio@cox.net>

Date

Jan 8, 2007, 01:46 UTC

Message-ID

<7vr6u6z3x8.fsf@assigned-by-dhcp.cox.net>

In-Reply-To

<Pine.LNX.4.63.0701080158500.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> It used to ignore the return value of the helper function; now, it
> expects it to return 0, and stops iteration upon non-zero return
> values; this value is then passed on as the return value of
> for_each_reflog_ent().

Good idea.

> Further, it makes no sense to force the parsing upon the helper
> functions; for_each_reflog_ent() now calls the helper function with
> old and new sha1, the email, the timestamp & timezone, and the message.