Re: [PATCH 1/2] Sanitize for_each_reflog_ent()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 8, 2007, 12:18 UTC
Message-ID: <Pine.LNX.4.63.0701081316110.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vr6u6z3x8.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sun, 7 Jan 2007, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Further, it makes no sense to force the parsing upon the helper
> > functions; for_each_reflog_ent() now calls the helper function with
> > old and new sha1, the email, the timestamp & timezone, and the message.
> 
> Perhaps.  I did it that way deliberately because all existing
> users did not have to pay overhead of parsing.

My reasoning is that invalid entries should rather be ignored than be taken into account. So, to verify that you are not walking invalid data, you have to parse it anyway.

Ciao, Dscho